Deterministic cycle keys #1520
Open
Deterministic cycle keys #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #1519 by offering an alternative method for generating context keys for the
cycletag when using "simple syntax".Rather than using a string representation of objects returned from
parse_expression(), we combine the object's class name and input argument, separated by a hyphen.For example, given a identifier that gets parsed to a
Liquid::VariableLookup, instead of a key containing something like"<Liquid::VariableLookup:0x00005632631bc858>", which changes with every occurrence of{% cycle %}, we would get"VariableLookup-x". Wherexis the input argument.Extra care has been taken to handle
Liquid::C::Expressionobjects. Hence the use ofobject.respond_to?(:evaluate)and the reason for generating key strings at the same time as parsing each expression.